Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SecurityProblemSupport bean after AdviceTrait created #728

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Change SecurityProblemSupport bean after AdviceTrait created #728

wants to merge 3 commits into from

Conversation

aafwu00
Copy link
Contributor

@aafwu00 aafwu00 commented Dec 30, 2021

SecurityProblemSupport bean depends on AdviceTrait bean

Description

HandlerExceptionResolver created by WebMvcAutoConfiguration, but ProblemSecurityAutoConfiguration created before WebMvcAutoConfiguration.
Import(SecurityProblemSupport) annotation working before created HandlerExceptionResolver.

If you don't define custom AdviceTrait bean, it doesn't well working.
So this patch fix problem.

Motivation and Context

This fixes #707

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@aafwu00
Refactoring: remove duplicate code, using ProblemHttpConfigurer
d3d2feb
@aafwu00
fix create SecurityProblemSupport bean after AdviceTrait created
f9798a7 
cause, HandlerExceptionResolver created by WebMvcAutoConfiguration, but ProblemSecurityAutoConfiguration created before WebMvcAutoConfiguration.
Import(SecurityProblemSupport) annotation working before created HandlerExceptionResolver.

If you don't define custom AdviceTrait bean, it doesn't well working.
So SecurityProblemSupport bean depends on AdviceTrait bean
@awattez awattez mentioned this pull request May 30, 2022
Open
@MALPI MALPI requested a review from danielrohe January 12, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderYastrebov AlexanderYastrebov Awaiting requested review from AlexanderYastrebov

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando

@whiskeysierra whiskeysierra Awaiting requested review from whiskeysierra

@danielrohe danielrohe Awaiting requested review from danielrohe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails to work with Spring Security after upgrading to Spring Boot 2.5
1 participant
@aafwu00